[sourcekitd-test] When setting -fmodules-cache-path also set -fmodules #29437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing header interface generation, we interpret clang command-line arguments in `initInvocationByClangArguments` and attempt to setup a matching Swift compiler invocation. One important argument is the module cache, but clang will only interpret `-fmodules-cache-path` if modules are enabled (typically with `-fmodules`). While the header itself might not need modules, Swift will import its own shims module and during testing this needs to honour lit's provided cache. So we add -fmodules in sourcekitd-test anytime we add -fmodules-cache-path. rdar://58836540
|
@swift-ci please test |
|
This is a follow-on to #29357 to make the -fmodules-cache-path part actually work. |
nathawes
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing header interface generation, we interpret clang command-line
arguments in
initInvocationByClangArgumentsand attempt to setup amatching Swift compiler invocation. One important argument is the module
cache, but clang will only interpret
-fmodules-cache-pathif modulesare enabled (typically with
-fmodules). While the header itself mightnot need modules, Swift will import its own shims module and during
testing this needs to honour lit's provided cache. So we add -fmodules
in sourcekitd-test anytime we add -fmodules-cache-path.
rdar://58836540